less aggressive realpathSync #1503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The realpath checks were added because in some environments node_modules is symlinked and we need to account for that. But they also mean that if any directory that appears in the index isn't present it can cause a crash, and that can indeed happen when output from a previous build is still present and hasn't been updated yet. This should hopefully achieve both goals by only resolving the top-level workingDir, and that only after proving that it's present. Not doing realpath on every individual inner directory is OK because we control those.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The realpath checks were added because in some environments node_modules is symlinked and we need to account for that. But they also mean that if any directory that appears in the index isn't present it can cause a crash, and that can indeed happen when output from a previous build is still present and hasn't been updated yet.
This should hopefully achieve both goals by only resolving the top-level workingDir, and that only after proving that it's present.
Not doing realpath on every individual inner directory is OK because we control those.