Add @glimmer/reference
as a virtual package
#1513
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another fix to #1487
The fix in #1495 turned out to be incomplete and didn't solve my actual problem (which I reduced away in my report). The actual import in the app was for
@glimmer/reference
, which internally imports from@glimmer/validator
. I think because in@glimmer/reference
'spackage.json
it has its own dep on@glimmer/validator
it escapes this rule and acquired the actual copy innode_modules
, causing the duplication.It seems like this would also be a problem if you, say, imported from
@glimmer/runtime
(which imports from@glimmer/reference
and, in turns,@glimmer/validator
)? I don't personally have that particular use case but I could see that happening. Do we just wait and see or is there something more targeted hard-coding that we should do specifically for@glimmer/validator
?