vite find assets & build copy assets #1736

patricklx · 2023-12-19T15:49:57Z

resolves addon & app assets from their origin (not rewritten-app)
copies addons & apps public assets from origin (not rewritten-app)

patricklx · 2023-12-21T13:35:26Z

packages/vite/src/assets.ts

+      const publicAppFiles = glob.sync('**/*', {
+        cwd: pubDir,
+      });
+      for (const publicAppFile of publicAppFiles) {


we do not copy the app assets that are available in app pkg meta.assets, because vite does bundle its own asset files. We only need the app public files

packages/vite/src/hbs.ts

ef4 · 2024-03-12T14:09:10Z

Discussion notes from office hours:

let's use this.emitFile instead of manual file writing
let's use send in the middleware as in https://github.com/embroider-build/embroider/pull/1839/files. This avoids the node_modules remap.
let's try to let vite's stock public folder support handle the app, and our plugin only handles the addons (must ensure our plugin is installed after vite's)

* this.emitFile * send * use vite's stock public folder support, use enfore:post

BlueCutOfficial · 2024-03-19T15:14:13Z

@patricklx what methodology did you use to test the PR? I noticed that it doesn't include the removal of the piece of code that writes the assets in the rewritten app.

patricklx · 2024-03-19T15:20:15Z

@patricklx what methodology did you use to test the PR? I noticed that it doesn't include the removal of the piece of code that writes the assets in the rewritten app.

this is what i did

I remove compatPrebuild from vite config
pnpm ember b
manually delete assets from rewritten app
run vite build
check that assets are in dist

patricklx · 2024-03-19T15:22:05Z

Maybe the code you changed also affects some package metadata? expecially public-assets?

packages/vite/src/assets.ts

patricklx · 2024-03-20T08:39:02Z

packages/vite/src/assets.ts

@@ -66,7 +68,7 @@ export function assets(): Plugin {
            this.emitFile({
              type: 'asset',
              source: readFileSync(join(pkg.root, path)),
-              fileName: dest.slice(1),
+              fileName: join('.', dest),


interesting, the result for join('.', './a-file') or join('.', '/a-file') is always 'a-file', nice

I changed the code to posix.resolve(‘/’, dest).slice(1) as suggested by Ed, it works as expected with my test setup (no problem in the middleware either) 👍

packages/vite/src/assets.ts

…he dest path of the emitted file

BlueCutOfficial · 2024-03-28T18:33:50Z

@patricklx for info tomorrow I'll work on the PR to clean-up the compat-app-builder :)

patricklx marked this pull request as draft December 19, 2023 19:06

patricklx force-pushed the vite-copy-assets branch 2 times, most recently from 471f4a9 to f67133b Compare December 21, 2023 13:33

patricklx marked this pull request as ready for review December 21, 2023 13:34

patricklx commented Dec 21, 2023

View reviewed changes

patricklx changed the title ~~vite copy assets to correct folder~~ fux vite build Dec 21, 2023

patricklx changed the title ~~fux vite build~~ fix vite build Dec 21, 2023

patricklx force-pushed the vite-copy-assets branch 5 times, most recently from 03e3f3e to 9692e8f Compare December 22, 2023 09:53

patricklx commented Dec 22, 2023

View reviewed changes

packages/vite/src/hbs.ts Outdated Show resolved Hide resolved

patricklx force-pushed the vite-copy-assets branch from 3b57f2a to cf1e41f Compare December 22, 2023 10:29

patricklx changed the title ~~fix vite build~~ vite build copy assets Feb 9, 2024

patricklx force-pushed the vite-copy-assets branch 4 times, most recently from e2038c9 to e7b6465 Compare February 15, 2024 10:08

patricklx changed the title ~~vite build copy assets~~ vite handle assets & build copy assets Mar 12, 2024

patricklx changed the title ~~vite handle assets & build copy assets~~ vite find assets & build copy assets Mar 12, 2024

patricklx force-pushed the vite-copy-assets branch 4 times, most recently from e799ad3 to bb40dad Compare March 12, 2024 16:19

patricklx and others added 2 commits March 12, 2024 17:23

copy assets to correct folder

1b1dadb

middleware to find addon assets

e87d947

patricklx force-pushed the vite-copy-assets branch 2 times, most recently from 2192ea9 to c335877 Compare March 19, 2024 14:14

patricklx added 6 commits March 19, 2024 15:18

use

d703350

* this.emitFile * send * use vite's stock public folder support, use enfore:post

copy assets to correct folder

3dde472

use vite public asset handling

cc4d78e

do not override app assets

64f5199

use post middleware

912326a

fix filter

87ddbc9

patricklx force-pushed the vite-copy-assets branch from 5fc919f to 87ddbc9 Compare March 19, 2024 14:18

get publicDir&mode in configResolved

659abf2

BlueCutOfficial reviewed Mar 19, 2024

View reviewed changes

packages/vite/src/assets.ts Outdated Show resolved Hide resolved

BlueCutOfficial force-pushed the vite-copy-assets branch from 39a12cf to a865db9 Compare March 20, 2024 08:11

patricklx commented Mar 20, 2024

View reviewed changes

packages/vite/src/assets.ts Outdated Show resolved Hide resolved

BlueCutOfficial mentioned this pull request Mar 20, 2024

Move public-assets handling to stage 3 #1839

Closed

make sure / and ./ can match when comparing assets URL, "normalize" t…

45e96e5

…he dest path of the emitted file

BlueCutOfficial force-pushed the vite-copy-assets branch from a865db9 to 45e96e5 Compare March 26, 2024 14:46

ef4 merged commit e1142b1 into embroider-build:main Mar 28, 2024
93 checks passed

BlueCutOfficial mentioned this pull request Mar 29, 2024

Public assets handling/ clean up stage 2 #1859

Merged

mansona added the enhancement New feature or request label Apr 4, 2024

github-actions bot mentioned this pull request Apr 4, 2024

Prepare Release #1865

Closed

github-actions bot mentioned this pull request Apr 15, 2024

Prepare Release #1873

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

vite find assets & build copy assets #1736

vite find assets & build copy assets #1736

patricklx commented Dec 19, 2023 •

edited

Loading

patricklx Dec 21, 2023 •

edited

Loading

ef4 commented Mar 12, 2024

BlueCutOfficial commented Mar 19, 2024 •

edited

Loading

patricklx commented Mar 19, 2024

patricklx commented Mar 19, 2024 •

edited

Loading

patricklx Mar 20, 2024

BlueCutOfficial Mar 26, 2024

BlueCutOfficial commented Mar 28, 2024

vite find assets & build copy assets #1736

vite find assets & build copy assets #1736

Conversation

patricklx commented Dec 19, 2023 • edited Loading

patricklx Dec 21, 2023 • edited Loading

Choose a reason for hiding this comment

ef4 commented Mar 12, 2024

BlueCutOfficial commented Mar 19, 2024 • edited Loading

patricklx commented Mar 19, 2024

patricklx commented Mar 19, 2024 • edited Loading

patricklx Mar 20, 2024

Choose a reason for hiding this comment

BlueCutOfficial Mar 26, 2024

Choose a reason for hiding this comment

BlueCutOfficial commented Mar 28, 2024

patricklx commented Dec 19, 2023 •

edited

Loading

patricklx Dec 21, 2023 •

edited

Loading

BlueCutOfficial commented Mar 19, 2024 •

edited

Loading

patricklx commented Mar 19, 2024 •

edited

Loading