Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecations warnings in resolver transform #2033

Merged

Conversation

mkszepp
Copy link
Contributor

@mkszepp mkszepp commented Jul 8, 2024

Since ember v5.9 there are deprecation warnings while build

DEPRECATION: The this property on path nodes is deprecated, use head.type instead
DEPRECATION: The parts property on path nodes is deprecated, use head and tail instead

As described in #1967 (comment), we should replace all .parts and .this with non deprecated code.

fix #2031

@mkszepp
Copy link
Contributor Author

mkszepp commented Jul 8, 2024

@ef4 i hope everything is correct, otherwise let me know

@jrjohnson
Copy link
Contributor

We'd love to see this merged anything I can do to help?

@mansona mansona added the bug Something isn't working label Jul 16, 2024
@mansona mansona merged commit 49514bf into embroider-build:stable Jul 16, 2024
214 checks passed
@github-actions github-actions bot mentioned this pull request Jul 16, 2024
@mkszepp mkszepp deleted the remove-deprecations-in-resolver branch July 16, 2024 16:25
@bwbuchanan
Copy link

Does this need to get merged into main as well? I've been experimenting with running my app under vite and have seen these deprecation messages.

@mansona
Copy link
Member

mansona commented Sep 9, 2024

we periodically merge stable back into main so it will get included in that 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants