Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message when module cannot be found in webpack #720

Merged
merged 1 commit into from
Mar 11, 2021

Conversation

thoov
Copy link
Collaborator

@thoov thoov commented Mar 11, 2021

This fixes the "full path" of the source file of the error which allows it to be easier to copy and paste so you can inspect the file that is importing the module which does not exist.

Before:
Screen Shot 2021-03-05 at 10 29 37 AM

After:
Screen Shot 2021-03-11 at 10 32 01 AM

Notice how schema-helpers.js is missing in the first example so you would have to grep the whole directory to find out which file contained the bad import.

@thoov thoov added the enhancement New feature or request label Mar 11, 2021
Copy link
Contributor

@charlespierce charlespierce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rwjblue rwjblue merged commit 81abc28 into embroider-build:master Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants