Use "real modules" for ember-source when possible (3.27+) #740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seems fully-working with staticAddonTrees off, and with them on the apps boots but we have an issue with the test setup.
We weren't properly exposing the fact that you can also send config into `@embroider/webpack`.
|
I did a lot of yak shaving here but now we're in a good place. |
rwjblue
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does our first fully-static build of everything in ember-source!
This won't pass CI yet, I only fixed the canary case and now need to go back and add switches so we do things the older way on earlier ember versions.
Fixes #738.