Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update addon-shim to use ember-auto-import v2 final #828

Merged

Conversation

josemarluedke
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, https://github.com/ef4/ember-auto-import/blob/6b32fba32a9cb562a62e466e1094ba0c92bc9390/packages/ember-auto-import/package.json#L36 is a little bit difficult for us here.

Since ^0.40.0 can't drift to get 0.41.0 (current release), we have a bit of node_modules duplication / clashing.

@ef4 - Do we need to be concerned here?

@ef4
Copy link
Contributor

ef4 commented Jun 2, 2021

We could do a coordinated release of ember-auto-import and embroider so these don't disagree. But it's not a correctness problem. The shared internals are really a grab bag of useful utilities and they don't need to all be on one version.

This is another reason to do a 1.0 though, that would make these easier to manage.

@rwjblue
Copy link
Collaborator

rwjblue commented Jun 3, 2021

But it's not a correctness problem. The shared internals are really a grab bag of useful utilities and they don't need to all be on one version.

That's great, thank you for confirming.

@josemarluedke josemarluedke force-pushed the feat/update-auto-import branch from 4ac85de to 3ba3805 Compare June 7, 2021 23:58
@rwjblue rwjblue added internal bug Something isn't working and removed internal labels Jun 9, 2021
@rwjblue rwjblue merged commit 46fd827 into embroider-build:master Jun 9, 2021
@josemarluedke josemarluedke deleted the feat/update-auto-import branch June 9, 2021 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants