-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
initializes com.mysql.jdbc.TimeUtil.timeZoneMappings if needed (Connector/J 5.x) #259
initializes com.mysql.jdbc.TimeUtil.timeZoneMappings if needed (Connector/J 5.x) #259
Conversation
4a17d05
to
7e625e3
Compare
As far as I understand, Then, I'd suggest to...
|
7e625e3
to
164272d
Compare
I read the source carefully again. in:
type: mysql
host: localhost
user: user
password: pasas
database: embulk_test
table: test
driver_path: /tmp/mysql-connector-j-8.4.0/mysql-connector-j-8.4.0.jar
out:
type: stdout |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Basically looks good with a couple of suggestions.
embulk-input-mysql/src/main/java/org/embulk/input/mysql/MySQLInputPlugin.java
Outdated
Show resolved
Hide resolved
embulk-input-mysql/src/main/java/org/embulk/input/mysql/MySQLInputPlugin.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Dai MIKURUBE <dmikurube@acm.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks! |
Reviese #200
Accept com.mysql.cj.util.TimeUtil in addition to com.mysql.jdbc.TimeUtil
Connector/J changed TimeUtil class.