Skip to content

Commit

Permalink
fix(ld-sidenav): make toggle-outside work with collapse-trigger mouseout
Browse files Browse the repository at this point in the history
  • Loading branch information
borisdiakur committed Feb 14, 2023
1 parent b0479a8 commit 226f337
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,8 @@ export class LdSidenavToggleOutside implements InnerFocusable {
this.tooltipRef.hideTooltip()
}

private toggleSidenavCollapsedState = () => {
private toggleSidenavCollapsedState = (ev) => {
ev.stopPropagation() // prevents call of click outside handler
this.sidenav.toggle()
}

Expand Down
8 changes: 7 additions & 1 deletion src/liquid/components/ld-sidenav/test/ld-sidenav.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,13 @@ describe('ld-sidenav', () => {
)
btnHeaderToggle.focus = jest.fn()

btnToggleOutside.click()
const ev = new MouseEvent('click', { bubbles: true, cancelable: true })
btnToggleOutside.dispatchEvent(ev)
await page.waitForChanges()

// event propagation must be stopped to prevent call of click outside handler
expect(ev.cancelBubble).toBeTruthy()

jest.advanceTimersByTime(200)
await page.waitForChanges()

Expand Down

0 comments on commit 226f337

Please sign in to comment.