Skip to content

Commit

Permalink
fix(ld-sidenav): unhide elements on slide change
Browse files Browse the repository at this point in the history
Resolves #286
  • Loading branch information
borisdiakur committed May 4, 2022
1 parent 63572a6 commit 89ec4fa
Show file tree
Hide file tree
Showing 2 changed files with 54 additions and 2 deletions.
7 changes: 5 additions & 2 deletions src/liquid/components/ld-sidenav/ld-sidenav.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -139,9 +139,12 @@ export class LdSidenav {
// which may happen on screen resize or orientation change events.
if (!this.closable) {
this.el.classList.add('ld-sidenav--transitions')

this.ldSidenavCollapsedChange.emit(collapsed)
}
// The ldSidenavCollapsedChange event needs to be emitted even if the
// sidenav is currently not collapsible (when it is closable), because
// on breakpoint change its subcomponents need to be rendered according
// to the new state and thus need to update their state using the event.
this.ldSidenavCollapsedChange.emit(collapsed)
}

@Watch('open')
Expand Down
49 changes: 49 additions & 0 deletions src/liquid/components/ld-sidenav/test/ld-sidenav.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1735,4 +1735,53 @@ describe('ld-sidenav', () => {
expect(page.root).toMatchSnapshot()
})
})

it('updates hidden state for compoenents in slider and subnavs on slide change when closable', async () => {
const page = await newSpecPage({
components: sidenavComponents,
html: getSidenavWithSubnavigation({
collapsible: true,
collapsed: true,
narrow: true,
}),
})
const ldSidenav = page.root
mockFocus(page)
jest.advanceTimersByTime(0)
await page.waitForChanges()

expect(ldSidenav).toHaveClass('ld-sidenav--collapsed')
expect(ldSidenav).not.toHaveClass('ld-sidenav--closable')

const mediaQueries = matchMedia.getMediaQueries()
matchMedia.useMediaQuery(mediaQueries[0])
await page.waitForChanges()

expect(ldSidenav).toHaveClass('ld-sidenav--collapsed')
expect(ldSidenav).toHaveClass('ld-sidenav--closable')

const ldSidenavNavitemArtInt =
ldSidenav.querySelector<HTMLLdSidenavNavitemElement>(
'ld-sidenav-slider > ld-sidenav-navitem:nth-child(4)'
)
ldSidenavNavitemArtInt.shadowRoot.querySelector('button').dispatchEvent(
new MouseEvent('mousedown', {
button: 0,
})
)
await page.waitForChanges()
expect(ldSidenav.classList.contains('ld-sidenav--has-active-subnav')).toBe(
true
)
expect(ldSidenav).not.toHaveClass('ld-sidenav--collapsed')
expect(ldSidenav).toHaveClass('ld-sidenav--closable')

expect(
ldSidenav.querySelectorAll('.ld-sidenav-slider__hidden').length
).toEqual(0)

expect(
ldSidenav.querySelectorAll('.ld-sidenav-subnav__hidden').length
).toEqual(0)
})
})

0 comments on commit 89ec4fa

Please sign in to comment.