Skip to content

Commit

Permalink
fix(ld-sidenav): truncate long words in nav header
Browse files Browse the repository at this point in the history
  • Loading branch information
borisdiakur committed Sep 21, 2023
1 parent d31779e commit a93f496
Show file tree
Hide file tree
Showing 4 changed files with 39 additions and 6 deletions.
13 changes: 13 additions & 0 deletions screenshot/builds/master.json
Original file line number Diff line number Diff line change
Expand Up @@ -19504,6 +19504,19 @@
"isLandscape": false,
"isMobile": false
},
{
"id": "4df0ed6a",
"image": "8513cd52278926a95d7b2299296d9087.png",
"userAgent": "default",
"desc": "ld-sidenav header truncates text in header",
"testPath": "./src/liquid/components/ld-sidenav/test/ld-sidenav.e2e.ts",
"width": 600,
"height": 600,
"deviceScaleFactor": 1,
"hasTouch": false,
"isLandscape": false,
"isMobile": false
},
{
"id": "171fb2c3",
"image": "0ec4bccd78c16f24b8352b0a15f2934b.png",
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,8 @@
outline-offset: var(--ld-sidenav-navitem-bg-inset);
position: relative;
text-decoration: none;
transition: opacity var(--ld-sidenav-transition-duration-collapse-expand)
transition:
opacity var(--ld-sidenav-transition-duration-collapse-expand)
var(--ld-sidenav-transition-delay-collapse-expand) linear,
transform var(--ld-sidenav-transition-duration-collapse-expand) ease;

Expand Down Expand Up @@ -107,7 +108,8 @@
:host(.ld-sidenav-header--closed) &,
:host(.ld-sidenav-header--collapsed) & {
transform: translateX(var(--ld-sidenav-translate-x-delta));
transition: visibility 0s
transition:
visibility 0s
calc(
var(--ld-sidenav-transition-duration-collapse-expand) +
var(--ld-sidenav-transition-delay-collapse-expand)
Expand Down Expand Up @@ -150,8 +152,8 @@
place-content: center;
touch-action: manipulation;
transform: translateX(var(--ld-sp-6));
transition: transform var(--ld-sidenav-transition-duration-collapse-expand)
ease,
transition:
transform var(--ld-sidenav-transition-duration-collapse-expand) ease,
opacity var(--ld-sidenav-transition-duration-collapse-expand) linear;
width: var(--ld-sidenav-navitem-icon-size);
will-change: transform; /* fixes rendering issue */
Expand Down Expand Up @@ -210,7 +212,8 @@

:host(.ld-sidenav-header--closed) &,
:host(.ld-sidenav-header--collapsed-fully) & {
transition: visibility 0s
transition:
visibility 0s
calc(2 * var(--ld-sidenav-transition-duration-collapse-expand)) linear,
transform var(--ld-sidenav-transition-duration-collapse-expand) ease,
opacity calc(var(--ld-sidenav-transition-duration-collapse-expand) * 0.5)
Expand Down Expand Up @@ -253,11 +256,12 @@

.ld-sidenav-header__slot-wrapper {
-webkit-box-orient: vertical;
-webkit-line-clamp: 2;
-webkit-line-clamp: 1;
display: -webkit-box;
max-height: var(--ld-sidenav-header-height); /* required in Safari */
overflow: hidden;
position: relative;
text-overflow: ellipsis;
word-break: break-word;
z-index: 2;
}
16 changes: 16 additions & 0 deletions src/liquid/components/ld-sidenav/test/ld-sidenav.e2e.ts
Original file line number Diff line number Diff line change
Expand Up @@ -980,6 +980,22 @@ describe('ld-sidenav', () => {
const result = await page.compareScreenshot()
expect(result).toMatchScreenshot()
})

it('truncates text in header', async () => {
const page = await getPageWithContent(
`
<ld-sidenav open collapsible narrow>
<ld-sidenav-header href="#" slot="header">
A title which is super long and should be truncated, because it is too long.
</ld-sidenav-header>
</ld-sidenav>`,
{ reducedMotion: true }
)
page.waitForChanges()

const result = await page.compareScreenshot()
expect(result).toMatchScreenshot()
})
})

describe('stacking', () => {
Expand Down

1 comment on commit a93f496

@vercel
Copy link

@vercel vercel bot commented on a93f496 Sep 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully deployed to the following URLs:

liquid – ./

liquid-oxygen.vercel.app
liquid-git-main-uxsd.vercel.app
liquid-uxsd.vercel.app

Please sign in to comment.