Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ld-input - issue with entering negative numbers #401

Closed
danielweber90 opened this issue Aug 8, 2022 · 2 comments · Fixed by #413
Closed

ld-input - issue with entering negative numbers #401

danielweber90 opened this issue Aug 8, 2022 · 2 comments · Fixed by #413
Assignees
@borisdiakur
Labels
bug An issue describing unexpected or malicious behaviour. confirmed This label indicates that the issue has been reproduced and verified by the core team. released

Comments

@danielweber90
Copy link

Bug description

When entering negative numbers into an ld-input element of type number, the - character is ignored the first time. You either have to press - twice, or enter any digit, remove it and press - again.

Steps to reproduce the behavior

  1. Click on an ld-input element with property type = "number"
  2. Press the -
  3. Type any number
  4. Remove input
  5. Press the - again

Expected behavior
- should appear the first time you hit -

Actual behavior

First time you press -, input is ignored

Screenshots

If applicable, add screenshots to help explain your problem.

liquid_design_input_bug.mov

Details about device, OS, browser (including versions)

  • Device: MacBook Pro (Retina, 15', Mid 2015)
  • OS: macOS Monterey v 12.5
  • Browser: Google Chrome / Safari
  • Version: 104.0.5112.79 (Official Build) (x86_64) / 15.6 (17613.3.9.1.5)
@renet renet added bug An issue describing unexpected or malicious behaviour. confirmed This label indicates that the issue has been reproduced and verified by the core team. labels Aug 11, 2022
@renet
Copy link
Member

renet commented Aug 11, 2022

Thank you for your detailed bug report! I was able to reproduce this issue and we'll prioritize and provide a bugfix asap.

@borisdiakur borisdiakur added the in progress This label indicates that the issue is currently being worked on. label Aug 25, 2022
@borisdiakur borisdiakur self-assigned this Aug 25, 2022
borisdiakur added a commit that referenced this issue Aug 25, 2022
@borisdiakur
fix(ld-input): make sure minus character is not ignored
fdbb486 
Resolves #401
@borisdiakur borisdiakur mentioned this issue Aug 25, 2022
Merged
12 tasks
borisdiakur added a commit that referenced this issue Aug 25, 2022
@borisdiakur
fix(ld-input): make sure minus character is not ignored
4b66a06 
Resolves #401
borisdiakur added a commit that referenced this issue Aug 26, 2022
@borisdiakur
fix(ld-input): make sure minus character is not ignored
722c9f9 
Resolves #401
github-actions bot pushed a commit that referenced this issue Aug 26, 2022
@semantic-release-bot
chore(release): 2.4.4 [skip ci]
c3c0d3a 
## [2.4.4](v2.4.3...v2.4.4) (2022-08-26)

### Bug Fixes

* **ld-input:** make sure minus character is not ignored ([722c9f9](722c9f9)), closes [#401](#401)
@borisdiakur
Copy link
Contributor

🎉 This issue has been resolved in version 2.4.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@borisdiakur borisdiakur added released done and removed in progress This label indicates that the issue is currently being worked on. labels Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@borisdiakur borisdiakur

Labels
bug An issue describing unexpected or malicious behaviour. confirmed This label indicates that the issue has been reproduced and verified by the core team. released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ld-input): make sure minus character is not ignored emdgroup-liquid/liquid
3 participants
@borisdiakur @renet @danielweber90