-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ld-select doesn't work when embedded inside a custom element #450
Comments
borisdiakur
added a commit
that referenced
this issue
Dec 12, 2022
11 tasks
borisdiakur
added a commit
that referenced
this issue
Dec 12, 2022
borisdiakur
added a commit
that referenced
this issue
Dec 12, 2022
🎉 This issue has been resolved in version 4.1.11 🎉 The release is available on: Your semantic-release bot 📦🚀 |
borisdiakur
added a commit
that referenced
this issue
Dec 14, 2022
borisdiakur
added a commit
that referenced
this issue
Jan 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bug description
We are using the Liquid elements to build custom elements using Preact and publish them with ViteJS as library.
When designing the component without packaging it as a library, the
<ld-select />
behavior seems fine.We are wrapping our component using shadow root element open, our goal is to keep each custom element isolated from other one, as a fallback we can omit that shadow root but as a result other elements on our pages are messed with styles*.
(* style messing is not illustrated in the below repro-sandbox)
Steps to reproduce the behavior
Repro codesandbox: https://codesandbox.io/p/github/dpitois/liquid-selects/
Preact app
section, the options are displayPreact custom element
section, the options are not displaysrc/component/Custom.tsx
uses Liquid with direct import of web componentsrc/component/CustomReact.tsx
uses Liquid React bindingsExpected behavior
When wrapping Liquid elements inside custom elements the options should be display
Actual behavior
Options seem to be created in the DOM but the popper does not display them when wrapped inside a custom element.
Screenshots
ld-select
used inside a Preact app (bootstraped with ViteJS)ld-select
used inside a Preact custom element (bootstraped with ViteJS)Details about device, OS, browser (including versions)
We can move the reported issue as a Github discussion or Teams conversation, with internal tools we might give more specific context about the use case and how we reach the issue.
The text was updated successfully, but these errors were encountered: