Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: table does not have border #491

Closed
3 tasks done
vabe opened this issue Jan 26, 2023 · 1 comment · Fixed by #492
Closed
3 tasks done

bug: table does not have border #491

vabe opened this issue Jan 26, 2023 · 1 comment · Fixed by #492
Assignees
Labels
bug An issue describing unexpected or malicious behaviour. confirmed This label indicates that the issue has been reproduced and verified by the core team. released

Comments

@vabe
Copy link

vabe commented Jan 26, 2023

Prerequisites

Liquid version

@emdgroup-liquid/liquid@4.3.3

Framework bindings

React

Current behavior

The <LdTable> React component does not have the expected border. It might be caused by a conflict with Tailwind rules.

/* tailwind.css */

*, ::before, ::after {
    box-sizing: border-box;
    border-width: 0;
    border-style: solid;
    border-color: currentColor;
}

image

Expected behavior

The <LdTable> component should reproduce the same border as the <ld-table> web component:

image

Steps to reproduce

  1. Set up a React-based project (or use the provided sandbox from the documentation)
  2. Update Liquid version to latest (@emdgroup-liquid/liquid@4.3.3)
  3. Import and combine the necessary components to build a table
    import {
      LdTableCell,
      LdTableHeader,
      LdTableCol,
      LdTableColgroup,
      LdTableRow,
      LdTableBody,
      LdTableCaption,
      LdTableToolbar,
      LdTable,
    } from '@emdgroup-liquid/liquid/dist/react'
    
  4. Check the output

Code reproduction URL

https://stackblitz.com/edit/github-qxwopq

Additional information

  • The same issue is present in the NextJS-based sandbox application as well.
  • Tested and verified the bug in the following browsers:
    • Chrome
    • Edge
    • Firefox
@vabe vabe added bug An issue describing unexpected or malicious behaviour. triage An issue that needs assessment to determine its validity and urgency labels Jan 26, 2023
@borisdiakur borisdiakur added confirmed This label indicates that the issue has been reproduced and verified by the core team. in progress This label indicates that the issue is currently being worked on. and removed triage An issue that needs assessment to determine its validity and urgency labels Jan 26, 2023
@borisdiakur borisdiakur self-assigned this Jan 27, 2023
github-actions bot pushed a commit that referenced this issue Jan 27, 2023
## [4.3.5](v4.3.4...v4.3.5) (2023-01-27)

### Bug Fixes

* **ld-table:** add specificity to account for border resets ([5260c33](5260c33)), closes [#491](#491)
@borisdiakur
Copy link
Contributor

🎉 This issue has been resolved in version 4.3.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

@borisdiakur borisdiakur added released and removed in progress This label indicates that the issue is currently being worked on. labels Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue describing unexpected or malicious behaviour. confirmed This label indicates that the issue has been reproduced and verified by the core team. released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants