Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ld-card without padding #810

Closed
3 tasks done
borisdiakur opened this issue Jul 7, 2023 · 0 comments · Fixed by #839
Closed
3 tasks done

feat: ld-card without padding #810

borisdiakur opened this issue Jul 7, 2023 · 0 comments · Fixed by #839
Assignees
@borisdiakur
Labels
accepted Issues with this label are issues that the core team has accepted on to the roadmap. improvement Not a bug nor a feature. Refactoring of code would likely have this label.

Comments

@borisdiakur
Copy link
Contributor

Prerequisites

Describe the feature request

I'd like to have an option for the ld-card to not have a padding. I could use a CSS custom prop to customize the card, but it feels inconvenient.

Describe the use case

We often have cards which display images. In such cases it makes sense to not have a padding in the card

Describe preferred solution

Add a prop no-padding.

Describe alternatives

Maybe better: Allow overwriting the padding (e.g. via utility classes) by reducing the specificity.

Related code

No response

Additional information

No response
@borisdiakur borisdiakur added feature Issues that describe new features. triage An issue that needs assessment to determine its validity and urgency improvement Not a bug nor a feature. Refactoring of code would likely have this label. and removed feature Issues that describe new features. triage An issue that needs assessment to determine its validity and urgency labels Jul 7, 2023
@borisdiakur borisdiakur added accepted Issues with this label are issues that the core team has accepted on to the roadmap. in progress This label indicates that the issue is currently being worked on. labels Jul 20, 2023
@borisdiakur borisdiakur self-assigned this Jul 20, 2023
borisdiakur added a commit that referenced this issue Jul 20, 2023
@borisdiakur
feat(ld-card): zero-padding
0977eda 
Resolves #810
@borisdiakur borisdiakur mentioned this issue Jul 20, 2023
Merged
10 tasks
@borisdiakur borisdiakur removed the in progress This label indicates that the issue is currently being worked on. label Jul 20, 2023
borisdiakur added a commit that referenced this issue Jul 20, 2023
@borisdiakur
feat(ld-card): zero-padding
a2aaea3 
Resolves #810
borisdiakur added a commit that referenced this issue Jul 20, 2023
@borisdiakur
feat(ld-card): zero-padding
a090c00 
Resolves #810
github-actions bot pushed a commit that referenced this issue Jul 20, 2023
@semantic-release-bot
chore(release): 5.7.0 [skip ci]
2bee264 
# [5.7.0](v5.6.4...v5.7.0) (2023-07-20)

### Features

* **ld-card:** zero-padding ([a090c00](a090c00)), closes [#810](#810)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@borisdiakur borisdiakur

Labels
accepted Issues with this label are issues that the core team has accepted on to the roadmap. improvement Not a bug nor a feature. Refactoring of code would likely have this label.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(ld-card): zero-padding emdgroup-liquid/liquid
1 participant
@borisdiakur