Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ld-sidenav): change and centralize icon size #287

Merged
merged 1 commit into from
Mar 11, 2022
Merged

fix(ld-sidenav): change and centralize icon size #287

merged 1 commit into from
Mar 11, 2022

Conversation

renet
Copy link
Member

@renet renet commented Mar 11, 2022

Description

Reduces the icon size of the ld-sidenav-navitem to 32px (2rem) and refactor calculations to automatically adapt to a changed icon size in the future.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • unit tests
  • e2e tests
  • accessibility tests
  • tested manually

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes

@borisdiakur borisdiakur merged commit 916d465 into develop Mar 11, 2022
@borisdiakur borisdiakur deleted the feat/ld-sidenav-iconsize branch March 11, 2022 12:24
renet added a commit that referenced this pull request Mar 11, 2022
@renet
fix(ld-sidenav): change and centralize icon size (#287)
b37f2a3
github-actions bot pushed a commit that referenced this pull request Mar 11, 2022
@semantic-release-bot
chore(release): 1.2.1 [skip ci]
40e254d 
## [1.2.1](v1.2.0...v1.2.1) (2022-03-11)

### Bug Fixes

* **ld-sidenav:** change and centralize icon size ([#287](#287)) ([b37f2a3](b37f2a3))
* **ld-sidenav:** horizontal scrollbars visible on windows ([5dc7222](5dc7222))
github-actions bot pushed a commit that referenced this pull request Mar 28, 2022
@semantic-release-bot
chore(release): 1.3.0 [skip ci]
df2357d 
# [1.3.0](v1.2.1...v1.3.0) (2022-03-28)

### Bug Fixes

* **ld-accordion:** single mode scroll into view ([89deb05](89deb05))
* **ld-sidenav:** change and centralize icon size ([#287](#287)) ([916d465](916d465))
* **ld-sidenav:** horizontal scrollbars visible on windows ([273e374](273e374))

### Features

* **ld-accordion:** implement accordion component ([709ed6b](709ed6b)), closes [#127](#127)
@borisdiakur
Copy link
Contributor

🎉 This PR is included in version 1.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@borisdiakur borisdiakur borisdiakur approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@renet @borisdiakur