Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ld-select): add filter feature #379

Merged
merged 11 commits into from
Jul 25, 2022
Merged

feat(ld-select): add filter feature #379

merged 11 commits into from
Jul 25, 2022

Conversation

borisdiakur
Copy link
Contributor

@borisdiakur borisdiakur commented Jul 16, 2022 •
edited
Loading

Description

This PR adds the possibility to filter options on the ld-select component.

Resolves #238

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • unit tests
  • e2e tests
  • accessibility tests
  • tested manually

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes

@vercel
Copy link

vercel bot commented Jul 16, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
liquid ✅ Ready (Inspect) Visit Preview Jul 25, 2022 at 8:48AM (UTC)

@borisdiakur borisdiakur marked this pull request as ready for review July 21, 2022 07:56
@borisdiakur borisdiakur requested a review from renet July 21, 2022 07:56
renet
renet requested changes Jul 21, 2022
View reviewed changes
package.json Show resolved Hide resolved
src/liquid/components/ld-select/ld-select.tsx Show resolved Hide resolved
src/liquid/components/ld-select/ld-select.tsx Show resolved Hide resolved
src/liquid/components/ld-select/ld-select.tsx Outdated Show resolved Hide resolved
src/liquid/components/ld-select/ld-select.tsx Outdated Show resolved Hide resolved
src/liquid/components/ld-select/ld-select.tsx Show resolved Hide resolved
src/liquid/components/ld-select/ld-select.tsx Outdated Show resolved Hide resolved
@borisdiakur borisdiakur requested a review from renet July 21, 2022 17:38
renet
renet approved these changes Jul 25, 2022
View reviewed changes
Copy link
Member

@renet renet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pre-approving, but please resolve the comment first.

src/liquid/components/ld-select/ld-select.tsx Show resolved Hide resolved
@borisdiakur borisdiakur merged commit 52a620b into develop Jul 25, 2022
@borisdiakur borisdiakur deleted the feat/ld-select_filter branch July 25, 2022 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renet renet renet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add search / autocomplete functionality/option to Select component
3 participants
@borisdiakur @renet @semantic-release-bot