Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ld-select): creatable mode #490

Merged
merged 2 commits into from
Jan 31, 2023
Merged

feat(ld-select): creatable mode #490

merged 2 commits into from
Jan 31, 2023

Conversation

borisdiakur
Copy link
Contributor

@borisdiakur borisdiakur commented Jan 26, 2023 •
edited
Loading

Description

This PR includes the creatable mode 🪄

Resolves #478

Type of change

  • Feature

Is it a breaking change?

  • No

How Has This Been Tested?

  • unit tests
  • e2e tests

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • New and existing tests pass locally with my changes

@vercel
Copy link

vercel bot commented Jan 26, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
liquid ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 27, 2023 at 4:26PM (UTC)

@borisdiakur borisdiakur force-pushed the feat/ld-select_creatable branch from 1961119 to 8dddfad Compare January 26, 2023 19:51
@borisdiakur borisdiakur force-pushed the feat/ld-select_creatable branch from 8dddfad to 63095d9 Compare January 27, 2023 16:20
@borisdiakur borisdiakur force-pushed the feat/ld-select_creatable branch from 63095d9 to 2ad3ac1 Compare January 27, 2023 16:21
@borisdiakur borisdiakur marked this pull request as ready for review January 27, 2023 16:21
@borisdiakur borisdiakur requested a review from renet January 27, 2023 16:21
@borisdiakur borisdiakur requested a review from renet January 31, 2023 14:06
@renet renet merged commit 7c8d7e7 into main Jan 31, 2023
@renet renet deleted the feat/ld-select_creatable branch January 31, 2023 14:14
@borisdiakur
Copy link
Contributor Author

🎉 This PR is included in version 4.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renet renet renet approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: Creatable Select
2 participants
@borisdiakur @renet