[RF]: MultiEchoData class #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Beginning of class-style refactoring to ease up the global shenanigans going on in `tedana.py`. Created a MultiEchoData class (`interfaces/data.py`) to hold input multi-echo data, echo times, create masks, etc. Made stub classes for other features that can be used to class-ify other aspects of the code. I still think that the API should be function-based, but this might help behind the scenes so that related information is stored together.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Beginning of class-style refactoring to ease up the global shenanigans going on in
tedana.py. I created a MultiEchoData class (interfaces/data.py) to hold input multi-echo data, echo times, create masks, etc. I also made stub classes for other features that can be used to class-ify other aspects of the code (i.e.,T2S()andTEDModelFitter())I still think that the API should be function-based, but this might help behind the scenes so that related information is stored together.