Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Theme selector #5

Closed
emibcn opened this issue Sep 27, 2020 · 5 comments · Fixed by #57
Closed

Add Theme selector #5

emibcn opened this issue Sep 27, 2020 · 5 comments · Fixed by #57
Assignees
@emibcn
Labels
enhancement New feature or request good first issue Good for newcomers Hacktoberfest Simple issues suitable Hacktoberfest PRs javascript Javascript knowledge needed material/ui Related to Material/UI dependency react React knowledge needed tests Issues related to adding or fixing tests Translations ui/ux Issues related to design/UI/UX

Comments

@emibcn
Copy link
Owner

emibcn commented Sep 27, 2020 •
edited
Loading

Let the user select his/her preferred theme from light or dark:
@emibcn emibcn added enhancement New feature or request good first issue Good for newcomers Hacktoberfest Simple issues suitable Hacktoberfest PRs react React knowledge needed javascript Javascript knowledge needed labels Sep 27, 2020
@greyGroot
Copy link

hi, i would like to work on this one. Could you please assign it to me? I will work on it during hacktoberfest.

@emibcn
Copy link
Owner Author

emibcn commented Sep 28, 2020

@greyGroot All yours!!

@emibcn emibcn mentioned this issue Oct 13, 2020
Merged
@emibcn
Copy link
Owner Author

emibcn commented Nov 15, 2020

Hello @greyGroot !! Any news on this issue? Do you need any help?

@greyGroot
Copy link

greyGroot commented Nov 17, 2020 •
edited
Loading

OMG, i totally forgot about this issue. @emibcn i'm really sorry. Sorry and now i don't have free time for this. Please, forgive me.

@emibcn
Copy link
Owner Author

emibcn commented Nov 17, 2020

Don't worry, it's not that bad ;)

If you have some code, please, push to your cloned repo and open a PR. This way, me or someone else will be able to finish it. If not, never mind, me or someone else will write it all :P

@emibcn emibcn mentioned this issue Apr 24, 2021
Merged
@emibcn emibcn assigned emibcn and unassigned greyGroot Apr 24, 2021
@emibcn emibcn added material/ui Related to Material/UI dependency tests Issues related to adding or fixing tests Translations ui/ux Issues related to design/UI/UX labels Apr 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emibcn emibcn

Labels
enhancement New feature or request good first issue Good for newcomers Hacktoberfest Simple issues suitable Hacktoberfest PRs javascript Javascript knowledge needed material/ui Related to Material/UI dependency react React knowledge needed tests Issues related to adding or fixing tests Translations ui/ux Issues related to design/UI/UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add theme selector emibcn/covid
2 participants
@emibcn @greyGroot