Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes fixed stuff on top always have higher z-index #16

Merged
merged 2 commits into from
Oct 8, 2020

Conversation

mandy6720
Copy link
Contributor

@emibcn I'm not sure if this is what you were looking for but I felt like the slider and tooltip would look better if they were placed on top. #6

Screen Shot 2020-10-08 at 10 07 41 AM

@emibcn
Copy link
Owner

emibcn commented Oct 8, 2020

That solves some problems. Still seeing the map tooltips appearing some times outside the view (now does not interferes with the Slider: good!).

Does using Material/UI tooltip would be better than ReactTooltip (current)? I used this one due to performance (only one object for all territories in the SVG), but I was still not using MaterualUI, then.

If you prefer to treat that on a different issue&PR, we can merge this one and keep going.

@mandy6720
Copy link
Contributor Author

mandy6720 commented Oct 8, 2020

@emibcn Sure! If you're cool with me handling that in a separate issue, that would be awesome if we could merge this one in 😄
Also, when we merge this one, we'll get installation instructions in the readme for future contributors

@emibcn emibcn merged commit 0254361 into emibcn:master Oct 8, 2020
@emibcn
Copy link
Owner

emibcn commented Oct 8, 2020

Merged! Building...

@emibcn
Copy link
Owner

emibcn commented Oct 8, 2020

Thanked! https://github.com/emibcn/covid#thanks-to

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants