Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #17 - Add some lateral margin to Slider on non-small devices #21

Merged
merged 2 commits into from
Oct 10, 2020

Conversation

mblaul
Copy link
Contributor

@mblaul mblaul commented Oct 9, 2020

  • Adding a small amount of left and right margin to the slider on large displays
  • Removing style props from Slider component so class styles are not overridden

I only added a small amount of margin, if you want something more extreme let me know and I can update it!
spacing

* Adding a small amount of left and right margin to the slider on large displays
* Removing style props from Slider component so class styles are not overridden
Copy link
Owner

@emibcn emibcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks almost great, just a couple of comments in the review.

app/src/Widget/List.jsx Outdated Show resolved Hide resolved
app/src/Widget/List.jsx Outdated Show resolved Hide resolved
@mblaul
Copy link
Contributor Author

mblaul commented Oct 9, 2020

@emibcn Thanks for the review and comments. Sorry about that!
I have updated this PR to address those points.

@mblaul mblaul requested a review from emibcn October 9, 2020 21:04
@emibcn emibcn merged commit 37654f7 into emibcn:master Oct 10, 2020
@emibcn
Copy link
Owner

emibcn commented Oct 10, 2020

Thanked!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants