Skip to content

Commit

Permalink
qmk: use the default GCC version for AVR
Browse files Browse the repository at this point in the history
Upstream previously recommended GCC 8 when targeting AVR because
of binary size concerns. They have since removed this warning in
<qmk/qmk_firmware#24206>, as more recent GCC
versions have resolved the issues.

Building `keyboardio/model01` before:

     * The firmware size is fine - 26984/28672 (94%, 1688 bytes free)

And after:

     * The firmware size is fine - 27200/28672 (94%, 1472 bytes free)

+216 bytes (1.008× the total size) is not a big deal. Since upstream
is fine with it these days, we can be too, and not keep around an
unsupported compiler just for QMK.
  • Loading branch information
emilazy committed Nov 21, 2024
1 parent 377cea9 commit e5c7f8c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pkgs/by-name/qm/qmk/package.nix
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ python3.pkgs.buildPythonApplication rec {
gnumake
pkgsCross.avr.buildPackages.binutils
pkgsCross.avr.buildPackages.binutils.bintools
pkgsCross.avr.buildPackages.gcc8
pkgsCross.avr.buildPackages.gcc
pkgsCross.avr.libcCross
];

Expand Down

0 comments on commit e5c7f8c

Please sign in to comment.