Fix bug causing tooltips with dynamic content to shrink

Affects `.on_hover_text(…)` with dynamic content (i.e. content that changes over time). * Closes #5167
emilk · Sep 25, 2024 · 2078eaa · 2078eaa
1 parent f97f850
commit 2078eaa
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 0 deletions.
diff --git a/crates/egui/src/response.rs b/crates/egui/src/response.rs
@@ -790,6 +790,10 @@ impl Response {
     #[doc(alias = "tooltip")]
     pub fn on_hover_text_at_pointer(self, text: impl Into<WidgetText>) -> Self {
         self.on_hover_ui_at_pointer(|ui| {
+            // Prevent `Area` auto-sizing from shrinking tooltips with dynamic content.
+            // See https://github.com/emilk/egui/issues/5167
+            ui.set_max_width(ui.spacing().tooltip_width);
+
             ui.add(crate::widgets::Label::new(text));
         })
     }
@@ -803,6 +807,10 @@ impl Response {
     #[doc(alias = "tooltip")]
     pub fn on_hover_text(self, text: impl Into<WidgetText>) -> Self {
         self.on_hover_ui(|ui| {
+            // Prevent `Area` auto-sizing from shrinking tooltips with dynamic content.
+            // See https://github.com/emilk/egui/issues/5167
+            ui.set_max_width(ui.spacing().tooltip_width);
+
             ui.add(crate::widgets::Label::new(text));
         })
     }
@@ -822,6 +830,10 @@ impl Response {
     /// Show this text when hovering if the widget is disabled.
     pub fn on_disabled_hover_text(self, text: impl Into<WidgetText>) -> Self {
         self.on_disabled_hover_ui(|ui| {
+            // Prevent `Area` auto-sizing from shrinking tooltips with dynamic content.
+            // See https://github.com/emilk/egui/issues/5167
+            ui.set_max_width(ui.spacing().tooltip_width);
+
             ui.add(crate::widgets::Label::new(text));
         })
     }

diff --git a/tests/test_size_pass/src/main.rs b/tests/test_size_pass/src/main.rs
@@ -103,6 +103,12 @@ fn main() -> eframe::Result {
                     ui.label("World");
                     ui.label("Hellooooooooooooooooooooooooo");
                 });
+
+            ui.separator();
+
+            let time = ui.input(|i| i.time);
+            ui.label("Hover for a tooltip with changing content")
+                .on_hover_text(format!("A number: {}", time % 10.0));
         });
     })
 }