eframe window changes size constantly on Hyprland

[RegenJacob]

Describe the bug
I'm on Hyprland and when I open an eframe app this happens:

2023-11-24.20-28-00.mp4

It worked in 0.23 without those issues. Maybe related to #3625 ?

To Reproduce
Steps to reproduce the behavior:

1. Be on Hyprland (possibly on other Wayland Compositors too?)
2. Run eframe app in debug mode (didn't test release yet)
3. The window resizes like shown in the video

Expected behavior
Window shouldn't change the size

Desktop (please complete the following information):

• OS: Linux arch 6.6.2-zen1-1-zen (Hyprland on wayland)
• Version: eframe 0.24

[zeozeozeo]

Probably related to #3620

[RegenJacob]

Also doesn't work on wgpu feature enabled

[emilk]

Does RUST_LOG=trace give you any clues?

[ItsEthra]

This only happens when x11 feature is enabled.

EDIT: Happens because of this code

egui/crates/egui-winit/src/lib.rs

Lines 207 to 211 in 4dc964a

	// TODO remove this in winit 0.29
	// This hack make the window outer_position and size to be valid, X11 Only
	// That was happending because winit get the window state before the compositor adds decorations!
	#[cfg(all(feature = "x11", target_os = "linux"))]
	window.set_maximized(window.is_maximized());

When commented out window behaves normally.

EDIT2: As a workaround you could just disable x11 feature. I don't know if it's safe to just remove this line because of the comment above and I don't have a x11 compositor to make a proper fix. Maybe @emilk have a better idea about this.

EDIT3: I guess this can be fixed by disabling this hack when wayland feature is enabled.

[emilk]

Nice find @ItsEthra - @konkitoman wrote that set_maximized - Do we really need it @konkitoman ? It seems like a bad idea. Maybe it should be moved to window initialization instead of running it each frame?

[emilk]

Potential fix: #3643

[konkitoman]

Nice find @ItsEthra - @konkitoman wrote that set_maximized - Do we really need it @konkitoman ? It seems like a bad idea. Maybe it should be moved to window initialization instead of running it each frame?

Is not really needed, that can be removed.

But the position will be off by 2..12 pixels on X11 Plasma