Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

There is on very rare occasions a case where a panic occurred #4178

Closed
rustbasic opened this issue Mar 16, 2024 · 1 comment · Fixed by #4868
Closed

There is on very rare occasions a case where a panic occurred #4178

rustbasic opened this issue Mar 16, 2024 · 1 comment · Fixed by #4868
Labels
bug Something is broken

Comments

@rustbasic
Copy link
Contributor

There is on very rare occasions a case where a panic occurred at line 2,132 of context.rs when a Viewport exit.
( On screens with different pixels_per_point. )
@rustbasic rustbasic added the bug Something is broken label Mar 16, 2024
This was referenced Mar 16, 2024
Closed
Closed
@rustbasic rustbasic changed the title There is on very rare occasions a case where a panic occurred when a Viewport exit. There is on very rare occasions a case where a panic occurred Mar 20, 2024
@emilk
Copy link
Owner

emilk commented Mar 29, 2024

Please run with RUST_BACKTRACE=1 so we get a stack trace to the error.

Also, naming just the line number isn't very useful when the code is changing every week

@rustbasic rustbasic mentioned this issue Mar 31, 2024
Merged
@rustbasic rustbasic mentioned this issue Jul 23, 2024
Merged
emilk added a commit that referenced this issue Sep 17, 2024
@rustbasic @emilk
Fix: panic when dragging window between monitors of different pixels_…
1474c17 
…per_point (#4868)

Fix: panic when dragging window between monitors of different
pixels_per_point

This will continue to help us as we develop `egui`.
I hope you agree with my defense of `panic`.

* Relate #3959
* Relate #4088

* Closes #4178
* Closes #4179


There is also a way to add log if necessary.
```
                log::debug!("Anti-panic behavior occurs");
```

---------

Co-authored-by: Emil Ernerfeldt <emil.ernerfeldt@gmail.com>
hacknus pushed a commit to hacknus/egui that referenced this issue Oct 30, 2024
@rustbasic @emilk @hacknus
Fix: panic when dragging window between monitors of different pixels_…
fcd4429 
…per_point (emilk#4868)

Fix: panic when dragging window between monitors of different
pixels_per_point

This will continue to help us as we develop `egui`.
I hope you agree with my defense of `panic`.

* Relate emilk#3959
* Relate emilk#4088

* Closes emilk#4178
* Closes emilk#4179


There is also a way to add log if necessary.
```
                log::debug!("Anti-panic behavior occurs");
```

---------

Co-authored-by: Emil Ernerfeldt <emil.ernerfeldt@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something is broken
Projects
None yet
Milestone
No milestone
2 participants
@emilk @rustbasic