Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement ViewportCommand::Screenshot on web #5425

Closed
emilk opened this issue Dec 3, 2024 · 0 comments · Fixed by #5438
Closed

Implement ViewportCommand::Screenshot on web #5425

emilk opened this issue Dec 3, 2024 · 0 comments · Fixed by #5438
Assignees
@lucasmerlin
Labels
eframe Relates to epi and eframe help wanted Extra attention is needed

Comments

@emilk
Copy link
Owner

emilk commented Dec 3, 2024 •
edited
Loading

So we can take screenshots on web, both using glow and wgpu backends.

This should be fairly simple.
@emilk emilk added the eframe Relates to epi and eframe label Dec 3, 2024
@emilk emilk added this to egui Dec 3, 2024
@emilk emilk moved this to Backlog in egui Dec 3, 2024
@emilk emilk added the help wanted Extra attention is needed label Dec 3, 2024
@emilk emilk mentioned this issue Dec 3, 2024
Open
@lucasmerlin lucasmerlin moved this from Backlog to In progress in egui Dec 5, 2024
@lucasmerlin lucasmerlin self-assigned this Dec 5, 2024
@lucasmerlin lucasmerlin mentioned this issue Dec 5, 2024
Merged
1 task
Wumpf pushed a commit that referenced this issue Dec 12, 2024
@lucasmerlin
Add screenshot support for eframe web (#5438)
6c1d695 
This implements web support for taking screenshots in an eframe app (and
adds a nice demo).
It also updates the native screenshot implementation to work with the
wgpu gl backend.

The wgpu implementation is quite different than the native one because
we can't block to wait for the screenshot result, so instead I use a
channel to pass the result to a future frame asynchronously.

* Closes <#5425>
* [x] I have followed the instructions in the PR template


https://github.com/user-attachments/assets/67cad40b-0384-431d-96a3-075cc3cb98fb
@github-project-automation github-project-automation bot moved this from In progress to Done in egui Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lucasmerlin lucasmerlin

Labels
eframe Relates to epi and eframe help wanted Extra attention is needed
Projects
egui
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add screenshot support for eframe web emilk/egui
2 participants
@emilk @lucasmerlin