Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't drag with secondary pointer button by default #578

Closed
mankinskin opened this issue Jul 23, 2021 · 3 comments
Closed

Don't drag with secondary pointer button by default #578

mankinskin opened this issue Jul 23, 2021 · 3 comments

Comments

@mankinskin
Copy link
Contributor

For a Context Menu #543 it is natural to use the second mouse button to open it by a click. Currently, when this happens on a draggable element, the right click is registered as a drag (same for left clicks). This is a problem for this feature, because context menus can't be opened on draggable elements.

In general, I think it is more common to use the left mouse button for initiating drags, anyways, not the right mouse button. Maybe the right mouse button should not register drags at all, by default?

In any case, #547 would still fix this, just wanted to put this up for discussion.

This was referenced Jul 23, 2021
@emilk
Copy link
Owner

emilk commented Jul 29, 2021

I agree that it makes sens to limit dragging windows using the primary mouse button.

@emilk emilk closed this as completed in e31312c Aug 15, 2021
@coderedart
Copy link
Contributor

just wanted to ask if this would affect future features like selecting multiple items (maybe in a list view sorta widget) by dragging with primary button, where we can choose secondary button to drag windows or such.

@emilk
Copy link
Owner

emilk commented Aug 15, 2021

@coderedart if a widget listens for drags (with Sense::Drag) then that wins over the window being moved. So when dragging a slider, you don't drag the window.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants