Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added interaction control fields to PlotUi #1132

Closed

Conversation

jbuckmccready
Copy link

This is a WIP for closing emilk/egui_plot#2. I changed the code to demonstrate what I describe in the issue regarding allow_drag and drag editing points. I'm creating this draft before continuing my work to get feedback regarding:

  1. Should I move the fields to PlotUi (breaking API change) or duplicate them to be on both Plot and PlotUi (non-breaking API change)? Or perhaps take a different approach entirely?
  2. I added a demo just to show editing (by dragging) points. This demo could be merged with the plot interactive demo already in place (since that interactive demo plot is currently left empty), left as its own demo, or removed entirely if deemed not useful.

- Plot editing demo demonstrates disabling dragging the plot bounds when a
  plot point is clicked and dragged
@jbuckmccready jbuckmccready changed the title Added allow_drag to PlotUi and plot editing demo to demonstrate Added interaction control fields to PlotUi Jan 18, 2022
@emilk
Copy link
Owner

emilk commented Jul 15, 2024

egui_plot has recently been moved to its own repository, at https://github.com/emilk/egui_plot

This will hopefully speed up its development by having more reviewers and maintainers.

Please re-open this PR at https://github.com/emilk/egui_plot/pulls

See also:

@emilk emilk closed this Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants