Add ability to override collapsing icons #1147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilk
approved these changes
Jan 22, 2022
| @@ -141,6 +141,7 @@ pub struct CollapsingHeader { | |||
| selectable: bool, | |||
| selected: bool, | |||
| show_background: bool, | |||
| icon: Option<Box<dyn FnOnce(&mut Ui, f32, &Response)>>, | |||
There was a problem hiding this comment.
pub type IconPainter = Box<dyn FnOnce(&mut Ui, f32, &Response)>; with a nice docstring would make this type simpler, and silence clippy
There was a problem hiding this comment.
I added the type alias and used it here.
I didn't use it in the icon function to keep the API simple (that way caller doesn't have to use Box::new). If trait aliases ever get stabilized we could use that, but who knows if that will ever happen.
emilk
approved these changes
Jan 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted custom icons for my tree so I added the ability to override's
CollapsingHeader's icon by passing a function that gets called instead ofpaint_icon.I personally like the pointy triangles but not the fact that they get thicker on hover.
Let's discuss if this is the best approach or if there's something better (e.g. implementing an
Icontrait or something). I can add a demo if we decide to move forward.2022-01-21.17-54-29.mp4