-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Bezier Shapes #1120 #1178
Add Bezier Shapes #1120 #1178
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! But there are still the clippy warnings to silence, and you need to run cargo fmt
. If you make the PR collaborative I can help you fix it!
Thank you @emilk, I fixed all Clippy warnings. I learned more from this journey. 👍 Kindly please review it again and hopefully there is a better solution for the code between lines 64-68 in paint_bezier.rs to have a widget that can manipulate the tasseller options. |
Hi, @emilk Clippy is still reporting some error message but it seems like it is aginst the old commit. None of them exists in the current latest commit now. How shall I do the next step? sorry since this is almost my "first" PR. :-) |
If you run
|
Aha, all from the test code in the |
Thank you! |
This PR introduces a typo, |
Closes #1120.
This is a replacement of the PR: #1155 for two reasons:
bezier_tolerance
.