Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scroll so that text cursor remains visible #1252

Merged
merged 3 commits into from
Feb 16, 2022
Merged

Conversation

emilk
Copy link
Owner

@emilk emilk commented Feb 15, 2022

Closes #165

This was very easy to implement thanks to #1247

@emilk emilk force-pushed the scroll-to-text-cursor branch from 4b5948a to ac2065e Compare February 15, 2022 16:18
@juancampa
Copy link
Contributor

I tested this and it works for the most part, the only issue is that it prevents you from scrolling. I think you need to call scroll_to_rect only when there's a change in the text or cursor position

@emilk
Copy link
Owner Author

emilk commented Feb 16, 2022

Good catch - fixed!

@emilk emilk merged commit 4af3cae into master Feb 16, 2022
@emilk emilk deleted the scroll-to-text-cursor branch February 16, 2022 20:34
emilk added a commit that referenced this pull request Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Let scrolling follow the text cursor in a multiline text edit widget
2 participants