Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Plot::allow_scroll #1382

Merged
merged 1 commit into from
Apr 3, 2022
Merged

Add Plot::allow_scroll #1382

merged 1 commit into from
Apr 3, 2022

Conversation

rukai
Copy link
Contributor

@rukai rukai commented Mar 20, 2022

I needed to disable scrolling as it conflicts with the scroll action of a ScrollArea but it is currently tied to the zoom functionality which I want to keep.

@rukai
Copy link
Contributor Author

rukai commented Apr 2, 2022

@emilk I left this PR as a draft as requested by the pull_request_template.md, waiting for green CI before marking as ready for review.
However that requires you to approve CI for this PR first.
And I suspect you arent looking at this PR yet because its still a draft.

So I'll mark this as ready to review and maybe the template should be changed to prevent newbie PRs getting stuck like this in the future.

@rukai rukai marked this pull request as ready for review April 2, 2022 06:49
@emilk
Copy link
Owner

emilk commented Apr 3, 2022

Good call @rukai - PR template updated in aa6a2bb

@@ -99,6 +101,7 @@ impl super::View for ContextMenus {
ui.end_row();
if ui.checkbox(&mut self.allow_drag, "Drag").changed()
|| ui.checkbox(&mut self.allow_zoom, "Zoom").changed()
|| ui.checkbox(&mut self.allow_scroll, "Scroll").changed()
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should really be part of the plot demo instead, but that's for another PR

@emilk emilk merged commit c203992 into emilk:master Apr 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants