Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Precompute rounded vertices #1547

Merged
merged 5 commits into from
Apr 30, 2022
Merged

Precompute rounded vertices #1547

merged 5 commits into from
Apr 30, 2022

Commits on Apr 30, 2022

  1. Tessellate: Implement precomputed vertices for rounding 

    Before:
demo_with_tessellate__realistic
                        time:   [328.77 us 329.22 us 329.70 us]
                        change: [-2.6116% -1.1978% +0.2520%] (p = 0.10 > 0.05)
                        No change in performance detected.

demo_no_tessellate      time:   [164.67 us 165.82 us 167.30 us]

demo_only_tessellate    time:   [159.34 us 159.85 us 160.67 us]

After:
demo_with_tessellate__realistic
                        time:   [309.48 us 309.92 us 310.41 us]
                        change: [-7.1042% -5.6164% -4.0262%] (p = 0.00 < 0.05)
                        Performance has improved.

demo_no_tessellate      time:   [160.44 us 161.30 us 162.49 us]
                        change: [-4.5692% -2.8617% -1.3549%] (p = 0.00 < 0.05)
                        Performance has improved.

demo_only_tessellate    time:   [139.45 us 140.23 us 141.25 us]
                        change: [-13.637% -12.245% -10.695%] (p = 0.00 < 0.05)
                        Performance has improved.

Not sure this is the right path. So i didn't bother to port Path::add_point()

Also we might want to fallback to computed vertices for radii >= 20 or add
another precomputed batch.
    @dbuch @emilk
    dbuch authored and emilk committed Apr 30, 2022
    Configuration menu
    Copy the full SHA
    b58b9e5 View commit details
    Browse the repository at this point in the history

  2. adapt to code review

    @dbuch @emilk
    dbuch authored and emilk committed Apr 30, 2022
    Configuration menu
    Copy the full SHA
    df838b9 View commit details
    Browse the repository at this point in the history

  3. silence clippy

    @emilk
    emilk committed Apr 30, 2022
    Configuration menu
    Copy the full SHA
    2880f13 View commit details
    Browse the repository at this point in the history

  4. Use the same precomputed vertices for circle quadrants and for circles

    @emilk
    emilk committed Apr 30, 2022
    Configuration menu
    Copy the full SHA
    2dab8d5 View commit details
    Browse the repository at this point in the history

  5. Update epaint changelog

    @emilk
    emilk committed Apr 30, 2022
    Configuration menu
    Copy the full SHA
    5933e72 View commit details
    Browse the repository at this point in the history