Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove calls to gl.getError in release builds #1583

Merged
merged 2 commits into from
May 5, 2022
Merged

Conversation

emilk
Copy link
Owner

@emilk emilk commented May 5, 2022

This slows down the web version a lot, especially on some browsers. I never meant to leave these calls in, but I forgot to remove them 🤦

I suspect this is responsible for the performance regression some have noticed in egui 0.18.

emilk added 2 commits May 5, 2022 22:58
This slows down the web version a lot, especially on some browsers
@emilk emilk merged commit e82b87c into master May 5, 2022
@emilk emilk deleted the remove-gl-geterror branch May 5, 2022 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant