Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some padding to the egui-wgpu uniform buffer for WebGL #1671

Merged
merged 4 commits into from
May 28, 2022

Conversation

expenses
Copy link
Contributor

I'm using egui-wgpu with the wgpu's WebGL backend. At the moment I get the following error on Chromium:

[.WebGL-0x38140334e800] GL_INVALID_OPERATION: It is undefined behaviour to use a uniform buffer that is too small.

with nothing rendering. I've encountered this issue before and have added some padding to the UniformBuffer struct. There is now no warning and it renders normally.

@expenses expenses marked this pull request as ready for review May 23, 2022 16:04
@expenses expenses requested a review from emilk May 23, 2022 17:16
@emilk
Copy link
Owner

emilk commented May 27, 2022

cargo fmt is unhappy

@emilk emilk merged commit abff2dc into emilk:master May 28, 2022
@emilk emilk mentioned this pull request Jun 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants