Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support to enable sRGB pixel format on NativeOptions. #2082

Closed
wants to merge 5 commits into from
Closed

Add support to enable sRGB pixel format on NativeOptions. #2082

wants to merge 5 commits into from

Conversation

ar37-rs
Copy link
Contributor

@ar37-rs ar37-rs commented Sep 25, 2022 •
edited
Loading

fixes: #2085

@ar37-rs ar37-rs changed the title eframe: Update doc shader_version on NativeOptions Add support to enable sRGB pixel format on NativeOptions. Sep 27, 2022
@ar37-rs ar37-rs mentioned this pull request Sep 27, 2022
Closed
@emilk
Copy link
Owner

emilk commented Oct 1, 2022

Does it perhaps work to just remove the with_srgb(…) line altogether instead?

@ar37-rs
Copy link
Contributor Author

ar37-rs commented Oct 1, 2022

@emilk i don't know, but the sRGB issue which causes crashing reported by @enomado, for me it's working fine though on windows with intel graphics and vmsvga driver on virtualbox as well, with or without sRGB being enabled

@njust
Copy link
Contributor

njust commented Oct 5, 2022

Removing with_srgb(false) from glutin::ContextBuilder fixed the error NoAvailablePixelFormat on Windows for me.

@emilk emilk mentioned this pull request Oct 5, 2022
Merged
@emilk emilk closed this in #2110 Oct 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Last commits with sRBG stuff crushes on Windows
3 participants
@ar37-rs @emilk @njust