Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split out ecolor crate #2399

Merged
merged 13 commits into from
Dec 6, 2022
Merged

Split out ecolor crate #2399

merged 13 commits into from
Dec 6, 2022

Conversation

Wumpf
Copy link
Collaborator

@Wumpf Wumpf commented Dec 6, 2022

Makes color its own crate and splits it in turn into lot of smaller modules.
Due to the generous imports of color structs this should not be a (hugely) breaking change!

@emilk
Copy link
Owner

emilk commented Dec 6, 2022

Thanks! Please silence clippy with #![allow(clippy::manual_range_contains)]. I'm not a big fan of that warning. Perhaps we can add it to allow-section in Cranky.toml?

@Wumpf Wumpf force-pushed the split-out-color-crate branch from e37cca8 to b7cceed Compare December 6, 2022 14:01
crates/ecolor/CHANGELOG.md Outdated Show resolved Hide resolved
crates/epaint/CHANGELOG.md Outdated Show resolved Hide resolved
@emilk emilk merged commit 5effc68 into emilk:master Dec 6, 2022
@Wumpf Wumpf deleted the split-out-color-crate branch December 7, 2022 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants