Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wgpu 0.16 #2884

Merged
merged 9 commits into from
Apr 21, 2023
Merged

wgpu 0.16 #2884

merged 9 commits into from
Apr 21, 2023

Conversation

niklaskorz
Copy link
Contributor

@niklaskorz niklaskorz commented Apr 7, 2023

wgpu 0.16 has been released today: https://github.com/gfx-rs/wgpu/releases/tag/v0.16.0

Not much to do actually, just the type changes of NonZeroU32 to u32 and the replacement of TextureFormat::describe with is_srgb.

@niklaskorz niklaskorz changed the title Prepare for wgpu 0.16 wgpu 0.16 Apr 20, 2023
@emilk emilk requested a review from Wumpf April 20, 2023 07:44
@niklaskorz niklaskorz marked this pull request as ready for review April 20, 2023 07:45
@niklaskorz
Copy link
Contributor Author

Blocked by gfx-rs/wgpu#3709 (can we get a 0.16.1? @cwfitzgerald 😇)

@cwfitzgerald
Copy link
Contributor

cwfitzgerald commented Apr 20, 2023

I don't think the right action here is to get us to downgrade, rather to get ash to upgrade. It was reverted due to Firefox not being able to use windows-rs

@emilk
Copy link
Owner

emilk commented Apr 20, 2023

libloading seems like a pretty small dependency, so we can add it to the skip-list in deny.toml.

I wonder how it wasn't caught by the cargo deny check in the wgpu CI though 🤔

Copy link
Collaborator

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since emil is good with libloading dupl we're good to go, changes look all straight forward. Tested web and after the fix I pushed yesterday stuff still works.
Just waiting for ci to finish, there was some hickup

deny.toml Outdated Show resolved Hide resolved
@Wumpf Wumpf merged commit f962378 into emilk:master Apr 21, 2023
@emilk
Copy link
Owner

emilk commented Apr 21, 2023

🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants