WIP. draft. make PlotPoints accept borrowed data #3521
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valyagolev
commented
Nov 2, 2023
| // self, | ||
| // ui: &mut Ui, | ||
| // build_fn: Box<dyn FnOnce(&mut PlotUi) -> R + 'a>, | ||
| // ) -> PlotResponse<R> { |
There was a problem hiding this comment.
I wonder about this one. why do we need to box the one-time callback? Everything seems to work without one
There was a problem hiding this comment.
It's to reduce the amount of generated code by making sure that the plotting function can be reused.
There was a problem hiding this comment.
understood, will undo the change
|
This will hopefully speed up its development by having more reviewers and maintainers. Please re-open this PR at https://github.com/emilk/egui_plot/pulls See also: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft PR. It's imperfect, not tested, and has some random edits. I have a question about one of them.
I'll make a better demo if this doesn't turn out to be such a bad idea (and after I've tried it in my projects)