Plot: Legend improvements

[EmbersArc]

Closes #409.

new_legend.mp4

This is based on the work in #363, so we should wait for that to be merged first. Sorry about the large PRs.

[emilk]

Nice additions!

[EmbersArc]

Thanks for the review! I made the changes.

I also tried to give the legend a background, but couldn't find a way to do it without doing all the size calculation myself. Do you happen to know a way to do this?

[emilk]

Thanks for the review! I made the changes.

I also tried to give the legend a background, but couldn't find a way to do it without doing all the size calculation myself. Do you happen to know a way to do this?

Sure, just add it to a Frame:

let frame = egui::Frame { … };
frame.show(ui, |ui| { /* legend ui */ });

[EmbersArc]

Sure, just add it to a Frame

I tried that and it looks great when the legend is on the top left:

But it doesn't work for all the other cases:

Is there a way to work around this issue? Maybe something like choosing an anchor point for the frame?

[emilk]

Sure, just add it to a Frame

I tried that and it looks great when the legend is on the top left:

…

Is there a way to work around this issue? Maybe something like choosing an anchor point for the frame?

I think this is a bug in Frame. Does this fix it:

diff --git a/egui/src/containers/frame.rs b/egui/src/containers/frame.rs
index 36b272c..6b41e31 100644
--- a/egui/src/containers/frame.rs
+++ b/egui/src/containers/frame.rs
@@ -175,10 +175,7 @@ impl Frame {
 
 impl Prepared {
     pub fn outer_rect(&self) -> Rect {
-        Rect::from_min_max(
-            self.outer_rect_bounds.min,
-            self.content_ui.min_rect().max + self.frame.margin,
-        )
+        self.content_ui.min_rect().expand2(self.frame.margin)
     }
 
     pub fn end(self, ui: &mut Ui) -> Response {

?

(that fix may introduce other problems, so please don't commit it)

[emilk]

I think we should get this in even without the legend background

[EmbersArc]

That was it! Works in all corners now. I'll add that in the next PR then. Thanks!