-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: On Windows, Strange IME display after update #4269 #4362
Conversation
let ime_rect_px = ime.rect * pixels_per_point; | ||
let mut need_set_ime_cursor_area = true; | ||
|
||
// On Wayland of Linux, repaints every frame Issue : See https://github.com/emilk/egui/pull/4254 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wasn't this fixed in #4269 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the problem occurs on Windows, we have moved it down to only apply on Linux.
need_set_ime_cursor_area = self.ime_rect_px != Some(ime_rect_px) | ||
&& self.egui_ctx.input(|i| !i.events.is_empty()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to treat Nix
specially here? Isn't this logic sound for all OSes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it should only be applied on Linux.
Definitely shouldn't be applied on Windows.
Please check with emilk
how to handle this on MacOs.
Fix: On windows, Strange IME display after update #4269