Fix: Menu not closing when clicking menu button

[fluxxcode]

Fixed an issue where the menu would not close if the menu button was clicked while the menu was already open.

Behaviour before:

before.mp4

Behaviour after:

after.mp4

The problem was that the logic to close the menu when the user presses outside the menu, closed the menu before the menu button registered the click. This means the following code gets no longer called when clicking on the menu button and instead the menu will be opened again.

// menu.rs : 326

        if (button.clicked() && root.is_menu_open(id))
            || button.ctx.input(|i| i.key_pressed(Key::Escape))
        {
            // menu open and button clicked or esc pressed
            return MenuResponse::Close;
        }

I fixed the problem by checking whether the mouse is currently hovering over the menu button before closing the menu.

[fluxxcode]

Closing as this is already fixed in the latest egui version