-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: The viewport stops working when the program is minimized. #4832
Conversation
window.request_redraw(); | ||
true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This reverts the changes you added in:
Won't this cause high CPU usage on Windows when minimized again?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it's ok as long as you don't keep calling request_repaint()
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If someone want to keep calling request_repaint()
but not call it when minimized
, someone can do the following.
It works fine.
let is_maximized = ui.input(|i| i.viewport().maximized.unwrap_or(false));
if !is_minimized {
ui.ctx().request_repaint();
}
Fix: The viewport stops working when the program is minimized. Fix: Logically, the weird parts have been normalized. **Issue :** The viewport stops working when the program is minimized. * Related #3321 * Related #3877 * Related #3985 * Closes #3972 * Closes #4772 * Related #4832 * Closes #4892 **Solution :** When `request_redraw()` is performed in Minimized state, the occasional screen tearing phenomenon has disappeared. ( Probably expected to be the effect of #4814 ) To address the issue of the `Immediate Viewport` not updating in Minimized state, we can call `request_redraw()`.
Fix: The viewport stops working when the program is minimized. Fix: Logically, the weird parts have been normalized. **Issue :** The viewport stops working when the program is minimized. * Related emilk#3321 * Related emilk#3877 * Related emilk#3985 * Closes emilk#3972 * Closes emilk#4772 * Related emilk#4832 * Closes emilk#4892 **Solution :** When `request_redraw()` is performed in Minimized state, the occasional screen tearing phenomenon has disappeared. ( Probably expected to be the effect of emilk#4814 ) To address the issue of the `Immediate Viewport` not updating in Minimized state, we can call `request_redraw()`.
Fix: The viewport stops working when the program is minimized. Fix: Logically, the weird parts have been normalized. **Issue :** The viewport stops working when the program is minimized. * Related emilk#3321 * Related emilk#3877 * Related emilk#3985 * Closes emilk#3972 * Closes emilk#4772 * Related emilk#4832 * Closes emilk#4892 **Solution :** When `request_redraw()` is performed in Minimized state, the occasional screen tearing phenomenon has disappeared. ( Probably expected to be the effect of emilk#4814 ) To address the issue of the `Immediate Viewport` not updating in Minimized state, we can call `request_redraw()`.
Fix: The viewport stops working when the program is minimized.
Issue :
The viewport stops working when the program is minimized.
Solution :
When
request_redraw()
is performed in Minimized state, the occasional screen tearing phenomenon has disappeared.( Probably expected to be the effect of #4814 )
To address the issue of the
Immediate Viewport
not updating in Minimized state, we can callrequest_redraw()
.