Add max click timings & distance to Options
#4986
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Azorlogh
commented
Aug 19, 2024
| .interactions | ||
| .entry(self.memory.viewport_id) | ||
| .or_default(), | ||
| &self.memory.options, |
There was a problem hiding this comment.
This isn't super pretty, but otherwise it conflicts with the mut access of memory above
emilk
requested changes
Aug 26, 2024
| @@ -2721,7 +2721,7 @@ fn register_rect(ui: &Ui, rect: Rect) { | |||
| return; | |||
| } | |||
|
|
|||
| let is_clicking = ui.input(|i| i.pointer.could_any_button_be_click()); | |||
| let is_clicking = ui.memory(|m| ui.input(|i| i.pointer.could_any_button_be_click(&m.options))); | |||
There was a problem hiding this comment.
This deadlocks (try holding down all modifier keys in the demo app)
1 task
|
There is an alternative PR for this in #4942 which I think uses a slightly better approach, and avoids the deadlock |
Oh I totally missed it! Yeah I agree that other one is a lot cleaner 👌 I'll close this one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the click timing & distance constants to the Options struct so they can be configured by users.
Note: This need came up as part of my investigation of mvlabat/bevy_egui#302. Essentially, on some platforms we are not guaranteed to have correct timekeeping so it's useful to be able to disable the max click duration in this case.