-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve documentation grammar and wording #5052
Conversation
Fixed conflicts |
Fixed conflicts |
needs |
Hi, cargo fmt does not change anything for me. |
@Swarkin hmm, maybe you are on an older rust version? Diff in /home/runner/work/egui/egui/crates/egui/src/memory/mod.rs at line 172:
#[cfg_attr(feature = "serde", serde(skip))]
pub dark_style: std::sync::Arc<Style>,
-
/// The default style for new [`Ui`](crate::Ui):s in light mode.
#[cfg_attr(feature = "serde", serde(skip))]
pub light_style: std::sync::Arc<Style>,
Diff in /home/runner/work/egui/egui/crates/egui/src/memory/mod.rs at line [18](https://github.com/emilk/egui/actions/runs/10832498741/job/30187822132?pr=5052#step:6:19)8:
///
/// Default: [`crate::Theme::Dark`].
pub fallback_theme: Theme,
-
/// The current system theme, used to choose between
/// dark and light style in case [`Self::theme_preference`] is [`ThemePreference::System`]. (you will need to remove the lines marked with |
Done |
Preview available at https://egui-pr-preview.github.io/pr/5052-patch-1 |
This PR aims to make the documentation comments easier to read and understand.
This PR aims to make the documentation comments easier to read and understand.