Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

egui_extras: Add TableBuilder::animate_scrolling #5159

Merged
merged 2 commits into from
Sep 26, 2024

Conversation

ecpost
Copy link
Contributor

@ecpost ecpost commented Sep 24, 2024

This will allow disabling the animation that occurs during scroll_to_row calls. Follows the same coding style as the other scroll options in TableBuilder.

@ecpost ecpost marked this pull request as ready for review September 24, 2024 21:09
Copy link

Preview available at https://egui-pr-preview.github.io/pr/5159-feature/table-scroll-animated
Note that it might take a couple seconds for the update to show up after the preview_build workflow has completed.

Change method name to more explicit `animate_scrolling`

Co-authored-by: Emil Ernerfeldt <emil.ernerfeldt@gmail.com>
@emilk emilk changed the title egui_extras: Add TableBuilder::animated egui_extras: Add TableBuilder::animate_scrolling Sep 26, 2024
@emilk emilk merged commit 25abb74 into emilk:master Sep 26, 2024
22 of 23 checks passed
@ecpost ecpost deleted the feature/table-scroll-animated branch September 26, 2024 17:40
hacknus pushed a commit to hacknus/egui that referenced this pull request Oct 30, 2024
This will allow disabling the animation that occurs during
`scroll_to_row` calls. Follows the same coding style as the other scroll
options in `TableBuilder`.

---------

Co-authored-by: Emil Ernerfeldt <emil.ernerfeldt@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants