Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drag-and-drop: keep cursor set by user, if any #5467

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Conversation

abey79
Copy link
Collaborator

@abey79 abey79 commented Dec 12, 2024

We used to always set the cursor to Grabbing when a drag and drop payload is set, but this shadows user code trying to set an alternative cursor (e.g. NoDrop). This PR no only change the cursor to Grabbing if is way previously set to Default.

@abey79 abey79 added the egui label Dec 12, 2024
Copy link

Preview available at https://egui-pr-preview.github.io/pr/5467-antoinedrag-cursor
Note that it might take a couple seconds for the update to show up after the preview_build workflow has completed.

@emilk emilk changed the title Only set the Grabbing cursor on drag if it hasn't already been set by the user Drag-and-drop: keep cursor set by user, if any Dec 12, 2024
@emilk emilk merged commit ba060a2 into master Dec 12, 2024
46 of 47 checks passed
@emilk emilk deleted the antoine/drag-cursor branch December 12, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants