eframe: don't prettify stored values #902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What ultimately ends up stored into a file is the HashMap<String, String>, which when prettified only nets three (depending on the settings) lines of "string": "long prettified string that's really hard to read because of the extra indentation and literal \n characters that are all just on one single line". Not prettifying the values in the first place makes it somewhat easier to read and also saves a bit of space.
|
The amount of space saved is actually quite significant. I tried getting rid of all the \n plus adjacent whitespace with The program I'm working on is for native, but I'm expecting the save file to be a few megabytes at least (growing larger the more stuff the user adds). Not sure if that's too big, but I'll see. I can work around it, but would prefer not to if it won't affect performance anyway. |
|
We should also consider switching to a binary alternative such as MsgPack |
emilk
approved these changes
Nov 28, 2021
emilk
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ultimately ends up stored into a file is the
HashMap<String, String>, which when prettified only nets three
(depending on the settings) lines of "string": "long prettified
string that's really hard to read because of the extra indentation and
literal \n characters that are all just on one single line".
Not prettifying the values in the first place makes it somewhat easier
to read and also saves a bit of space.
Closes https://github.com/emilk/egui/issues/THE_RELEVANT_ISSUE.