Add ability to customize the display of hover plot labels #934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isegal
commented
Dec 6, 2021
isegal
commented
Dec 6, 2021
egui/src/widgets/plot/items/mod.rs
Outdated
| elem: ClosestElem, | ||
| shapes: &mut Vec<Shape>, | ||
| plot: &PlotConfig<'_>, | ||
| _: &CustomLabelFunc, |
There was a problem hiding this comment.
Currently implemented only for the line chart. If this is the direction that we are good to go, happy to continue implementing for BarChart and BoxPlot.
emilk
requested changes
Dec 19, 2021
There was a problem hiding this comment.
Looks good to me (except for Option<&str> -> &str). Perhaps @EmbersArc also has some thoughts.
…e arg" This reverts commit 296caeb.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a feature candidate / RFC for #933
This is a work-in-progress POC to gauge whether there is interest in this feature. Happy to continue to make changes based on feedback.